Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

제휴문의시 페이지 생성 #23

Merged
merged 3 commits into from
Jun 20, 2024
Merged

제휴문의시 페이지 생성 #23

merged 3 commits into from
Jun 20, 2024

Conversation

gbwlxhd97
Copy link
Contributor

@gbwlxhd97 gbwlxhd97 commented Jun 19, 2024 •
edited
Loading

🎫 [167]

  1. 제휴문의 설문조사 제출완료 화면 구현했습니다. useState로 index페이지에서 성공 실패를 구분합니다.
  2. alliance api를 Promise를 then으로 처리하니까 return값이 들어오지 않아서 async await으로 코드를 수정했습니다.
const res = await applyContactInfo({
        contactInfo,
        region: region,
        reservationPlatform: selectedPlatformList,
        shouldInterview: selectedInterview,
      });
      if(res.status >= 201 && res.status < 300) {
        setIsSuccessSurvey(true);
      }

3.제휴문의 페이지에서 ApplyLink 버튼을 클릭하면 작동하지 않는 문제를 여차저차 해결했는데 useRef가 두 번 이용되서 좀 고민입니다
416973a
참고 부탁드립니다


🛠️ 작업 내용

image



🗒️ Note (optional)

@gbwlxhd97 gbwlxhd97 requested a review from VictoryJu June 19, 2024 15:44
VictoryJu
VictoryJu requested changes Jun 20, 2024
View reviewed changes
src/pages/alliance/index.tsx
<LedingApply />
<AllianceMain />
<AllianceBenefit />
<div ref={allianceContactRef}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오잉? 여기에 ref를 넣으면 하단까지 scrollIntoView가 되나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

찾아보면서 지피티 시키니까 작동은 잘 되긴합니다 신기하져?

src/pages/alliance/index.tsx Show resolved Hide resolved
src/components/Alliance/AllianceContact/AllianceContact.tsx Show resolved Hide resolved
src/components/Alliance/SuccessSurvey/SuccessSurvey.tsx Show resolved Hide resolved
@gbwlxhd97 gbwlxhd97 requested a review from VictoryJu June 20, 2024 13:19
@gbwlxhd97 gbwlxhd97 merged commit f918ff7 into main Jun 20, 2024
1 check passed
@gbwlxhd97 gbwlxhd97 deleted the feat/sucess-survey branch June 20, 2024 15:11
VictoryJu
VictoryJu reviewed Jun 20, 2024
View reviewed changes
src/pages/alliance/index.tsx
}

return () => {
document.removeEventListener('wheel', disableScroll);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setTimeout부분에서 remove를 해주고있어서 요부분은 나중에 없애시는거스로~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictoryJu VictoryJu VictoryJu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbwlxhd97 @VictoryJu